Fix chain optimization #2422
Merged
Fix chain optimization #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
optimize_proof
branch
2 times, most recently
from
e359a02 to
dd5433e
Compare
ineiti
force-pushed
the
optimize_proof
branch
from
dd5433e to
5f8d8a4
Compare
ineiti
force-pushed
the
get_full_proof
branch
from
9e1c4c8 to
ec337c7
Compare
ineiti
force-pushed
the
optimize_proof
branch
from
5f8d8a4 to
0ac18ec
Compare
ineiti
force-pushed
the
get_full_proof
branch
2 times, most recently
from
bc56a59 to
87a2411
Compare
ineiti
force-pushed
the
optimize_proof
branch
from
0ac18ec to
423e79a
Compare
ineiti
force-pushed
the
optimize_proof
branch
from
423e79a to
83cfe11
Compare
The current chain optimization is badly defined, as you need to give it a block, but for some blocks the optimization will always fail, as the nodes will not accept the new forward-links. This PR re-defines the chain optimization: - if given a skipchain-ID it optimizes the route from the genesis to the latest block - if given a random skipblock-ID, it optimizes that block only This will allow to crawl through all blocks and ask an optimization for every block that is lacking forward-links.
ineiti
force-pushed
the
optimize_proof
branch
from
83cfe11 to
cba6b1f
Compare
tharvik
reviewed
Dec 10, 2020
ineiti
force-pushed
the
optimize_proof
branch
from
2ad7078 to
03ca284
Compare
Co-authored-by: Valérian Rousset <tharvik@users.noreply.github.com>
ineiti
force-pushed
the
optimize_proof
branch
from
03ca284 to
de37616
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tharvik
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current chain optimization is badly defined, as you need to give it a block,
but for some blocks the optimization will always fail, as the nodes will not
accept the new forward-links.
This PR re-defines the chain optimization:
This will allow to crawl through all blocks and ask an optimization for every
block that is lacking forward-links.
Depends on #2423