TestGenerateCatalogWithExternalNodes

[MichelleArk]

resolves #9458

Problem

catalog from docs generate does not include external nodes, even though that was the case in 1.6. This is because starting from 1.7, the docs generate task started using a ResourceSelector which filters out empty nodes (e.g. external ones) as opposed to iterating over the manifest directly.

Solution

• Set include_empty_nodes=True in the ResourceTypeSelector for the generate task.
  • This indicates to the selector that 'empty' (e.g. nodes without raw_code, like external nodes) should be included in selection and make their way to the catalog
  • Same approach as was used to select external nodes in the ListCommand, which needed to select external nodes for the result even though they are not 'runnable': https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/task/list.py#L201
• Add a test that ensures generated catalogs include external nodes when those are available in the project

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
• This PR includes type annotations for new and modified functions

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6663846) 87.85% compared to head (f601794) 87.91%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9456      +/-   ##
==========================================
+ Coverage   87.85%   87.91%   +0.05%     
==========================================
  Files         160      160              
  Lines       21934    21934              
==========================================
+ Hits        19271    19284      +13     
+ Misses       2663     2650      -13     

Flag	Coverage Δ
integration	85.45% <ø> (+0.13%)	⬆️
unit	62.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[graciegoheen]

@MichelleArk What's the reason to backport to 1.1.latest? I think we only need to backport to 1.7.latest?

[MichelleArk]

Agreed! Think the 1.1.latest label was just fat-thumbed

[aranke]

LGTM, would this apply to exposures also?

[MichelleArk]

@aranke - good question! Exposures have their own handling for selection: https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/graph/selector.py#L168

This should not affect them.

[github-actions]

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-9456-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 06e55bb93ed771921d656807cd6bfa2dc1995b20
# Push it to GitHub
git push --set-upstream origin backport-9456-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-9456-to-1.7.latest.

[MichelleArk]

Manual backport: #9483