Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 11332 to 1.9.latest #11349

Open
wants to merge 1 commit into
base: 1.9.latest
Choose a base branch
from

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Mar 3, 2025

Backport 94b6ae1 from #11332

…ead (#11332)

* Push orchestration of batches previously in the `RunTask` into `MicrobatchModelRunner`

* Split `MicrobatchModelRunner` into two separate runners

`MicrobatchModelRunner` is now an orchestrator of `MicrobatchBatchRunner`s, the latter being what handle actual batch execution

* Introduce new `DbtThreadPool` that knows if it's been closed

* Enable `MicrobatchModelRunner` to shutdown gracefully when it detects the thread pool has been closed
@QMalcolm QMalcolm requested a review from a team as a code owner March 3, 2025 22:27
@cla-bot cla-bot bot added the cla:yes label Mar 3, 2025
@QMalcolm QMalcolm changed the base branch from main to 1.9.latest March 3, 2025 22:27
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 21 lines in your changes missing coverage. Please review.

Project coverage is 89.02%. Comparing base (5e5d3bd) to head (78c1f1d).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.9.latest   #11349      +/-   ##
==============================================
- Coverage       89.14%   89.02%   -0.13%     
==============================================
  Files             183      184       +1     
  Lines           23896    23911      +15     
==============================================
- Hits            21302    21286      -16     
- Misses           2594     2625      +31     
Flag Coverage Δ
integration 86.33% <86.73%> (-0.24%) ⬇️
unit 62.15% <32.14%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.15% <32.14%> (+0.03%) ⬆️
Integration Tests 86.33% <86.73%> (-0.24%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant