Allow sampling from snapshots and of snapshots #11311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Of note the parameterization of `test_resolve_event_time_filter` in tests/unit/context/test_providers.py is getting large and cumbersome. It may be time soon to split it into a few distinct tests to facilitate the necessity of fewer parametrized arguments for a given test.
Previously we were doing `isintance(a, class1) or (isinstance(a, class2)` but this can be simplified to `isintance(a, (class1, class2))`. Woops.
Notably we didn't have to add `insinstance(self.target, SnapshotConfig)` to the checks in `resolve_event_time_filter` because `SnapshotConfig` is a subclass of `NodeConfig`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11311 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 189 189
Lines 24170 24170
=======================================
Hits 21490 21490
Misses 2680 2680
Flags with carried forward coverage won't be shown. Click here to find out more.
|
QMalcolm
force-pushed
the
qmalcolm--11301-sampling-from-snapshots-and-of-snapshots
branch
from
21a9b1a to
acbd380
Compare
MichelleArk
approved these changes
Feb 14, 2025
QMalcolm
deleted the
qmalcolm--11301-sampling-from-snapshots-and-of-snapshots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11301
Problem
ref(my_snapshot)should be sample-able from a modelref(my_model)should be sample-able from a snapshotSolution
refs andsources in snapshotsref('a_snapshot')from modelsChecklist