Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to sample seeds #11304

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

QMalcolm
Copy link
Contributor

Resolves #11300

Problem

Refs of seeds couldn't be sampled

Solution

Allow for sampling of ref'd seeds

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@QMalcolm QMalcolm requested a review from a team as a code owner February 12, 2025 23:40
@cla-bot cla-bot bot added the cla:yes label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (a08255e) to head (cc48853).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11304   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         189      189           
  Lines       24169    24169           
=======================================
  Hits        21485    21485           
  Misses       2684     2684           
Flag Coverage Δ
integration 86.15% <100.00%> (ø)
unit 62.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.53% <100.00%> (ø)
Integration Tests 86.15% <100.00%> (ø)

@QMalcolm QMalcolm changed the title Qmalcolm 11300 ability to sample seeds Ability to sample seeds Feb 12, 2025
@QMalcolm QMalcolm force-pushed the qmalcolm--11300-ability-to-sample-seeds branch from 244a4ba to 317680f Compare February 12, 2025 23:53
Base automatically changed from qmalcolm--11299-single-sample-mode-flag to main February 13, 2025 21:59
@MichelleArk MichelleArk self-requested a review February 13, 2025 22:00
@MichelleArk
Copy link
Contributor

Test failures look relevant. Any ideas?

@QMalcolm QMalcolm force-pushed the qmalcolm--11300-ability-to-sample-seeds branch from 317680f to 9780f22 Compare February 13, 2025 22:02
@QMalcolm
Copy link
Contributor Author

Test failures look relevant. Any ideas?

I just rebased (necessary because the branch this branch was based on just got squash merged into main). Running the tests locally to see if I can reproduce the errors

@QMalcolm
Copy link
Contributor Author

Found failure in the action history. It does look relevant, but I'm also not getting that failure locally 🤔

@QMalcolm
Copy link
Contributor Author

It did just start failing for the new action as well though, and it seems to be the same test 🤔 🤔 🤔

@QMalcolm
Copy link
Contributor Author

@MichelleArk My guess is that there is some issue with data munging. I bet the string representation of the event_time column in the seed is being materialized as a string, and for whatever reason locally the sample filter is working against that string and in github it isn't. I'm going to specify a type for the column in the config for the seed, and hopefully that should fix the problem 🤞

@QMalcolm
Copy link
Contributor Author

Specifying the column_type seems to have done the trick 🎉

@QMalcolm QMalcolm merged commit 7041e58 into main Feb 13, 2025
57 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--11300-ability-to-sample-seeds branch February 13, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to sample seeds
2 participants