-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to sample seeds #11304
Ability to sample seeds #11304
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11304 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 189 189
Lines 24169 24169
=======================================
Hits 21485 21485
Misses 2684 2684
Flags with carried forward coverage won't be shown. Click here to find out more.
|
244a4ba
to
317680f
Compare
Test failures look relevant. Any ideas? |
317680f
to
9780f22
Compare
I just rebased (necessary because the branch this branch was based on just got squash merged into main). Running the tests locally to see if I can reproduce the errors |
Found failure in the action history. It does look relevant, but I'm also not getting that failure locally 🤔 |
It did just start failing for the new action as well though, and it seems to be the same test 🤔 🤔 🤔 |
@MichelleArk My guess is that there is some issue with data munging. I bet the string representation of the |
Specifying the |
Resolves #11300
Problem
Refs of seeds couldn't be sampled
Solution
Allow for sampling of ref'd seeds
Checklist