New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ColbertVectorStore as_retriever() #611

Merged

cbornet merged 1 commit into main from colbert-retriever

Jul 24, 2024

Collaborator

cbornet commented Jul 24, 2024 •

edited

Loading

It's important to respect the as_retriever signature as some LangChain components use it and expect a VectorStoreRetriever.

cbornet requested a review from epinzur

July 24, 2024 13:40


          Fix ColbertVectorStore as_retriever()

abf4c85

cbornet force-pushed the colbert-retriever branch from 1ccdb7a to abf4c85 Compare

July 24, 2024 14:13

epinzur approved these changes

View reviewed changes

cbornet merged commit e78d791 into main

22 checks passed

cbornet deleted the colbert-retriever branch

July 24, 2024 14:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet