Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move documents to tests for simple test scenarios #31

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

epinzur
Copy link
Collaborator

@epinzur epinzur commented Jan 20, 2025

Does this still make sense when we are moving towards testing get_adjacent() at the adapters?

@bjchambers
Copy link
Collaborator

I think this still makes sense.

  1. The in-memory integration tests may end up with more different sets of documents to test a wider range of cases. Thus, we may end up with more document sets.
  2. In those cases, we'll likely have some document sets only used in one or two tests.

That said, we should think about how to limit the size of the test from getting too large -- we could say that for in memory tests, we create a separate test_***.py file for each document set, describing what is being tested by that, etc.?

@epinzur epinzur merged commit e312881 into main Jan 21, 2025
6 checks passed
@epinzur epinzur deleted the move_docs branch January 21, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants