-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added tests of remaining transformers #113
Conversation
Test Results 8 files ± 0 8 suites ±0 2m 1s ⏱️ +26s Results for commit 583937b. ± Comparison against base commit c93576b. This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
fc235ba
to
94da13b
Compare
from typing_extensions import override | ||
|
||
|
||
class ParentTransformer(BaseDocumentTransformer): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I think it's useful to have this transformer (especially for LangFlow, etc.) but this could be a good thing to have an example of doing too. Specifically, if the user has already written code to put the path in the metadata... it wouldn't be too hard to just write the parent themselves.
We should definitely have some examples showing "here is how to set the metadata for X" rather than relying on hiding it all in transformers. Specifically, that enables the user to encode their own structured metadata.
This would be a good example to use, since it demonstrates "setting something like parent
in the metadata enables different kinds of navigation via the edges".
26aafb9
to
4e2422e
Compare
4e2422e
to
017cf4e
Compare
Pull Request Test Coverage Report for Build 13164213708Details
💛 - Coveralls |
5313962
to
583937b
Compare
Adds a new option to mark tests as
extra
. This requires the--runextras
flag on pytest to run.Adds tests for the transformers that were missing tests. Many require extras and are not tested against python 3.13.
Also simplifies the HierarchyLinkExtractor, now called the ParentTransformer.
This closes #83 and #59.