Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-13027: Fix V5VectorPostingsWriter to handle omitted ordinals correctly #1584

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jbellis
Copy link

@jbellis jbellis commented Feb 19, 2025

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@jbellis
Copy link
Author

jbellis commented Feb 19, 2025

Two issues:

  1. The assert is just incorrect, I think this was a brain fart when I wrote it
  2. "Create a Map of rowId -> ordinal" needs to skip OMITTED entries

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1584 rejected by Butler


1 new test failure(s) in 2 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴🔴 🔵🔵🔵🔵🔵🔵🔵

Found 4 known test failures

Copy link

@jkni jkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jbellis jbellis merged commit 5ecb085 into main Feb 19, 2025
467 of 476 checks passed
@jbellis jbellis deleted the 13027 branch February 19, 2025 23:14
@eolivelli eolivelli changed the title Fix V5VectorPostingsWriter to handle omitted ordinals correctly CNDB-13027: Fix V5VectorPostingsWriter to handle omitted ordinals correctly Feb 20, 2025
eolivelli added a commit that referenced this pull request Feb 20, 2025
…ectly (#1589)

(cherry picked from commit 5ecb085)

Porting of #1584 to the Jan25
release

---------

Co-authored-by: Jonathan Ellis <jbellis@datastax.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants