Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 96 #101

Merged
merged 14 commits into from
Oct 18, 2024
Merged

Issue 96 #101

merged 14 commits into from
Oct 18, 2024

Conversation

IoannaNika
Copy link
Collaborator

@IoannaNika IoannaNika commented Oct 17, 2024 •
edited
Loading

  • define filenames that were previously hard-coded, all tests pass for runCohortCharacterization.R
  • correct argument checks
  • replace recordKeepingFile argument with incrementalFolder for runTimeSeries, runVisitContext, runIncidenceRate, runIncludedSourceConcepts, runInclusionStatistics, runIndexEventBreakDown, runResolvedConcepts, runCohortRelationship, runCohortCharacterization.R
  • fix and adjust tests for runTimeSeries, runVisitContext, runIncidenceRate, runIncludedSourceConcepts, runInclusionStatistics, runIndexEventBreakDown, runResolvedConcepts, runCohortRelationship, runCohortCharacterization.R

@IoannaNika IoannaNika closed this Oct 17, 2024
@IoannaNika IoannaNika reopened this Oct 18, 2024
@ablack3 ablack3 merged commit 11e9918 into darwin_sprint Oct 18, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IoannaNika @ablack3