Hide banner on scroll #6441
Merged
Hide banner on scroll #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit d4b1e77): https://dart-dev--pr6441-feat-hidable-banner-crf0c7ca.web.app |
MaryaBelanger
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide banner when scrolling down the page by restructuring the style of pages to make the entire body scrollable, rather than just the page content. Then make other changes to account for that restructuring, such as increasing the scroll margins of headers.
Resolves #6406
This can be tested by navigating to different portions of the page, verifying the banner disappears, then reappears when scrolling back to the top of the page. The changes to the sidenav can be verified they didn't regress behavior by opening and scrolling the sidenav in both wide and narrow layouts.