Use root scss file for exports only #6436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit cd10805): |
MaryaBelanger
approved these changes
Feb 18, 2025
1 task
parlough
added a commit
that referenced
this pull request
Feb 19, 2025
Fixes #6439 which was caused by a CSS order change in #6436. Also fixes some of the related TODOs left by that change in order to fix the issue without reverting. Can test by toggling the menu in a narrow layout of the page, ensuring it is visible, then ensuring the page content is still visible as well once the menu is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts styles from the root
/src/_sass/site.scssfile into existing and new files that are focused on a specific component or element of the site. This helps maintainability and later review.This is in preparation for dark mode theming work.