-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added version note about wildcard variables language feature of Dart 3.7 #6432
Conversation
/gcbrun |
Visit the preview URL for this PR (updated for commit a75b9fb): |
Thank you for noticing this @ViktorVoloshko, great catch! This is definitely important to update. @munificent, what do you think about me rewriting the section completely? Or maybe removing it? For a rewrite, it could a bunch of different ways:
Or, we could leave it as-is with a note like the one in this PR (I'd move it right under the section heading), with a plan to remove/change/update later, when we're further from the latest version release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ViktorVoloshko! I'm going to merge this PR. Other stakeholders: I might open another PR to change the title of this section all together; will link to here for reference
/gcbrun |
Sorry for the delay, I was out all week. I agree that rewriting it eventually would be good. I would probably change the guideline to "PREFER using Then in the prose mention that if targeting Dart < 3.7 that you may need to use |
Dart 3.7 added wildcard variables language feature that prevents
_
identifiers from actually declaring a variable. So multiple_
in a single callback now possible.Added version note about this to according guideline.
Contribution guidelines:
dart format
.<?code-excerpt
need to be updated in their source.dart
file as well.