Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the variable name for accurate understanding. #6424

Merged
merged 8 commits into from
Feb 21, 2025

Conversation

J-Manoj-06
Copy link
Contributor

@J-Manoj-06 J-Manoj-06 commented Feb 16, 2025

This update improves the variable naming in the Dart regex example for accurate understanding:

Renamed numbersdigitsSequence.
Renamed allCharacterslettersOnly .

This changes are made in two directories:

  1. /examples/misc/test/library_tour/core_test.dart
  2. /src/content/libraries/dart-core.md

This ensures and follows the contributing guidelines.
As per the wish , the variables name are modifies for greater understanding.

Fixes #6410

Best regards,
Manoj J

This is the change for updating the webpage in the https://dart.dev/libraries/async/using-streams . Adding a Youtube video for the topic streams makes the user better to understand the topic and reduce the difficulties of them.
changed the variable names
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thinking to improve these examples @J-Manoj-06!

The changes overall look good and make sense to me, but I do have one suggestion to consider. Let me know what you think. Thanks again :D

Copy link
Contributor Author

@J-Manoj-06 J-Manoj-06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have change the variable name from digitsSequence -> digitSequence .
This changes are made in two directories :

  1. /examples/misc/test/library_tour/core_test.dart
  2. /src/content/libraries/dart-core.md

Image 1:

Screenshot 2025-02-21 201723

@J-Manoj-06
Copy link
Contributor Author

Waiting for further improvements. And sir , if you can see the visible changes then please react to this comment sir.
Best Regards,
Manoj J

@parlough
Copy link
Member

/gcbrun

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 49130e9):

https://dart-dev--pr6424-j-manoj-06-patch-3-ldlsyop9.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those adjustments! Looks great to me :)

@parlough parlough merged commit a3b7492 into dart-lang:main Feb 21, 2025
10 checks passed
@J-Manoj-06
Copy link
Contributor Author

@parlough Thank you sir!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect variable names - numbers and allCharacters
3 participants