Add tooling to programmatically update diagnostic-related files #6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit caebe07): https://dart-dev--pr6368-misc-update-diagnostics-tooling-6sc5mr1f.web.app |
parlough
changed the title
MaryaBelanger
approved these changes
Jan 29, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly moves some tooling from the SDK and doesn't need to be too closely reviewed. It adds
./dash_site generate-diagnosticsto update thesrc/_data/linter_rules.jsonandsrc/content/tools/diagnostic-messages.mdfiles from sources in the SDK.This is temporary and much of it will be expanded or replaced with logic in the static site generator to generate individual diagnostic message pages. Then it will be automatically ran every night, reducing the manual steps necessary. I'm proposing we land this so we can incrementally get to that point and enable simplifying the SDK implementation.