-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup for filtering and searching linter rules #6283
Conversation
Visit the preview URL for this PR (updated for commit 4c2aa02): https://dart-dev--pr6283-feat-filter-lint-rules-94adngwc.web.app |
@MaryaBelanger This is WIP from an implementation and style perspective, but I'd appreciate your initial thoughts: https://dart-dev--pr6283-feat-filter-lint-rules-qp9kzihy.web.app/tools/linter-rules#rules The current implementation is the result of prototyping, but I hope to make it more generic and flexible so it's expandable and a lot can be used on the glossary page as well. Thanks for taking a look :D |
This is awesome, it looks great. Half baked aside - The three of us should talk about documenting some kind of 'style guide' for the websites ahead of the UI work that Marya and I have started planning for Dart Getting Started and Flutter Fundamentals. |
8dc3f84
to
f522640
Compare
/gcbrun Edit: staging is not working |
@MaryaBelanger It looks like staging worked: https://dart-dev--pr6283-feat-filter-lint-rules-94adngwc.web.app/tools/linter-rules#rules |
These should have a title on hover (and a corresponding accessible label) now. It takes a second to appear as it's just using the built-in browser title for now. Once I add tooltip functionality for glossary work, I can revisit using that for these too.
Great idea. I couldn't come up with a perfect style and behavior for the stickiness, so if it's ok I'd like to revisit it later on.
Good point. I plan to revisit the individual lint pages soon and I'll see about reusing these icons. I cleaned up the implementation a bit, but will make it more generic and shared after when I adapt the components to work for the glossary as well. That way I don't unnecessarily over design the abstractions of the implementation :) Otherwise this is ready for review if you're fine with leaving those changes for follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! And yeah I was just spouting off ideas, it's definitely in a very impressive state as is and other ideas can be revisited
Staged: https://dart-dev--pr6283-feat-filter-lint-rules-94adngwc.web.app/tools/linter-rules#rules