Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Text in other languages was removed from anchors #6094

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

AmosHuKe
Copy link
Contributor

ref flutter/website#11151


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@AmosHuKe
Copy link
Contributor Author

cc @parlough

@parlough
Copy link
Member

/gcbrun

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating both files here too!!

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit f017bb0):

https://dart-dev--pr6094-patch-anchors-1-qthw0rov.web.app

@parlough parlough merged commit cd3d090 into dart-lang:main Sep 20, 2024
10 checks passed
@AmosHuKe AmosHuKe deleted the patch-anchors-1 branch September 20, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants