Edit dart pub token page #5717
Merged
Edit dart pub token page #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 506e088): |
|
|
||
| The tokens are stored in a | ||
| [user-wide config dir]({{site.repo.dart.org}}/cli_util/blob/71ba36e2554f7b7717f3f12b5ddd33751a4e3ddd/lib/cli_util.dart#L88-L118). | ||
| It stores these tokens in a [user-wide config directory][config-dir]. | ||
|
|
||
| It has three subcommands: `add`, `list` and `remove`. |
There was a problem hiding this comment.
suggestion (lite): This gets tricky with avoiding passive voice, but could we say something besides "It" again here (the previous sentence also starts with "It")
dart pub tokenhas three subcommands....- The subcommand has three subcommands of its own...
I don't have any good ideas, just a thought.
|
@MaryaBelanger : Thanks for this! I'll update this soon. |
atsansone
commented
Apr 16, 2024
|
@MaryaBelanger : PTAL. Thanks! |
Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
MaryaBelanger
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
As I pointed out in several suggestions, I don't think "invoke" is the right word to use for running a command.
- It's needlessly complex; "run" is universally understood
- None of the other command docs use it in their instructions
- If you look across the dart docs, "invoke" is defined as and always used to describe calling a method or some kind of class relationship. Using it for CLI is an unnecessary overload
Most of the other CLI docs just say "use the command ...".
Approving for the sake of progression.
Changed phrasing from `invoke` to `use`.
|
@MaryaBelanger : I agree with your assessment. I made the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3729