-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the code sample from dart web get started guide #5688
Conversation
Hi @jsiedentop! This is so helpful, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for thinking about this and for the PR!
The build is failing as the [!
highlight mechanism currently doesn't support multi-line spans. The goal is to transition away from this mechanism in the future, so support likely won't be added. To work around this limitation, you can add the brackets to each line :)
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
I haven't had a chance to set up the development environment locally to see why the build is failing. Thanks for taking a quick look. It's a bit offtopic but I have some feedback on the documentation: If someone wants to get started with Vanilla Dart on the web, the DevEx is currently suboptimal. My impression of the last few days, was that it takes good will and a lot of extra effort to get into web development with Dart. However, I've noticed that there is a lot going on at the moment (new web/js_interop libraries, wasm, extension types, more documentation). Would you be interested in me writing down my experiences in more detail in a suitable place? But if the topic doesn't fit into the agenda currently, I wouldn't create an issue. Unlike good wine, issues don't really get better with time 😉 |
You're right that the experience is evolving a lot recently and there's still a lot of work in progress, particularly for documentation. Beyond that, as you noticed, there are some developer experience tradeoffs with the new interop mechanisms. It's my understanding that some of these are unavoidable due to other goals (such as Wasm compatibility and performance), but it seems the team working on it is very interested in improving the developer experience where they can. So send feedback their way :)
Feedback is always appreciated, and is even more impactful while Dart's web story is continuing to evolve :D If you don't have anything super specific or just want one place to file your thoughts, https://github.com/dart-lang/sdk/issues is likely a good place to at least have your feedback be heard. However, if you have feedback related to specific portions, it can help to separate that discussion into more focused issues. The following table has some related topics and where feedback for them might be the most helpful.
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and the PR! Looks good to me :)
I pushed some more formatting fixes to fix the build and some other nearby cleanup.
Visit the preview URL for this PR (updated for commit 2c2d86d): https://dart-dev--pr5688-update-dart-web-example-3utizk7u.web.app |
I have discovered that the dart web get started code example does not match the new dart:web interface. Therefore I have updated the documentation.
Fixes: There is no specific issue, but it certainly helps #5674 and #5525
Contribution guidelines:
dart format
.<?code-excerpt
need to be updated in their source.dart
file as well.