Update outdated mention that factory constructors can return null. #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 51b9d7f): |
munificent
reviewed
Mar 7, 2024
| @@ -1728,7 +1728,7 @@ void main() { | |||
| ## Factory constructors | |||
|
|
|||
| Dart supports factory constructors, | |||
| which can return subtypes or even null. | |||
| which can return instances of a class or even subtypes. | |||
There was a problem hiding this comment.
Everything is an instance of a class in Dart (even null), so that doesn't say much. But you're exactly right that factory constructors can't return null anymore. That's a good catch. How about:
"which can return an instance of the surrounding class or even a subtype of it."
atsansone
approved these changes
Mar 20, 2024
|
Fixed in #5757. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory constructors no longer return null with null-safe Dart. Instead, they can be used to return instance of a class or subtypes.
Fixes #5506