Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension-types to sidenav for release #5550

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Conversation

MaryaBelanger
Copy link
Contributor

@MaryaBelanger MaryaBelanger commented Feb 14, 2024

Edit: Also fixes prev/next on surrounding pages.

Merge before the release

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Feb 14, 2024

Visit the preview URL for this PR (updated for commit 2c7ddaf):

https://dart-dev--pr5550-ext-type-sidenav-i45zu0pk.web.app

@parlough
Copy link
Member

parlough commented Feb 14, 2024

Can you also update the prev->next of the surrounding pages in this PR? Or I'd be happy to as well.

Sorry that they're not autogenerated yet...

@parlough parlough added the st.blocked Issue cannot continue until another action completes label Feb 14, 2024
@parlough parlough self-requested a review February 14, 2024 22:41
@MaryaBelanger
Copy link
Contributor Author

Oh yup, forgot that completely. Thanks!

@parlough parlough removed the st.blocked Issue cannot continue until another action completes label Feb 15, 2024
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaryaBelanger! Please land this whenever you're ready/happy :)

@MaryaBelanger MaryaBelanger merged commit f16a528 into main Feb 15, 2024
8 checks passed
atsansone pushed a commit to atsansone/site-www that referenced this pull request Mar 22, 2024
Edit: Also fixes prev/next on surrounding pages.

Merge before the release
@kevmoo kevmoo deleted the ext-type-sidenav branch August 20, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants