-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect rendering of Logical OR and Bitwise OR operator #5528
Fixed incorrect rendering of Logical OR and Bitwise OR operator #5528
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
Visit the preview URL for this PR (updated for commit fb4ddd4): https://dart-dev--pr5528-fix-incorrect-rendering-of-pipes-in-o-sxj949nq.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reporting and fixing this!
Your PR included a lot of formatting changes to the page, making it harder to review, but also breaking some of our tooling. Can you update the PR to instead just change the lines that need to be updated?
| shift | `<<` `>>` `>>>` | Left | | ||
| bitwise AND | `&` | Left | | ||
| bitwise XOR | `^` | Left | | ||
| bitwise OR | ` | ` | Left | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this entry will need to be fixed as well too: <code>|</code>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some issues with previous branch. I have opened a new pull request. Can you review that?
…-in-Operators-table' into fix/formatting-changes
Fixes #5527