Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect rendering of Logical OR and Bitwise OR operator #5528

Conversation

iambijayd
Copy link
Contributor

Fixes #5527

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

Copy link

google-cla bot commented Feb 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@parlough
Copy link
Member

/gcbrun

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit fb4ddd4):

https://dart-dev--pr5528-fix-incorrect-rendering-of-pipes-in-o-sxj949nq.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this!

Your PR included a lot of formatting changes to the page, making it harder to review, but also breaking some of our tooling. Can you update the PR to instead just change the lines that need to be updated?

| shift | `<<`    `>>`    `>>>` | Left |
| bitwise AND | `&` | Left |
| bitwise XOR | `^` | Left |
| bitwise OR | ` | ` | Left |
Copy link
Member

@parlough parlough Feb 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this entry will need to be fixed as well too: <code>&#124;</code>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some issues with previous branch. I have opened a new pull request. Can you review that?

@parlough parlough added the cla: yes Contributor has signed the Contributor License Agreement label Feb 11, 2024
@iambijayd iambijayd closed this Feb 11, 2024
@iambijayd iambijayd deleted the fix/Incorrect-rendering-of-pipes-in-Operators-table branch February 11, 2024 06:30
@parlough parlough mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect rendering of pipes in Operators table
3 participants