Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Dart FAQ #5479

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Revise Dart FAQ #5479

merged 4 commits into from
Feb 5, 2024

Conversation

atsansone
Copy link
Contributor

@atsansone atsansone commented Jan 22, 2024

Revised for currency.

Fixes #4673

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 22, 2024

Visit the preview URL for this PR (updated for commit 6ae11e6):

https://dart-dev--pr5479-fix-4673-evsp7an0.web.app

@MaryaBelanger
Copy link
Contributor

Can you update the PR description to explain whether you checked the page for any info that might be beneficial to preserve since it doesn't exist anywhere else on the site. I can't go through all of them but at a glance some of these warrant at least a single sentence added to their relevant corresponding pages, e.g. Why are generics covariant? probably deserves a mention on the generics page, something about AOT vs JIT tradeoffs on the dart compile page, etc.

@atsansone
Copy link
Contributor Author

@MaryaBelanger : I did in part. Maybe removal isn't the right move here. I'll take another look.

@atsansone atsansone marked this pull request as draft January 23, 2024 23:57
@parlough
Copy link
Member

parlough commented Jan 24, 2024

I think until someone has a chance to collect (today's) common questions and determine their answers, I think it's fine to delete this. It's one of the least visited pages.

It's just someone needs to go through each answer to determine if it is still relevant and if so, should it be documented elsewhere? Some cases, such as in the browser version support change you already made, already should have been. Other answers, even if they're still relevant, might already be documented elsewhere or not important enough to document.

I'm happy to discuss any of the entries if needed :)

@atsansone
Copy link
Contributor Author

@parlough @MaryaBelanger : I did discuss with @munificent and his views matched @parlough . I moved some information, but didn't do all of it yet. @MaryaBelanger : Would you prefer to have a full accounting first or can I remove and we can revisit after I/O?

@atsansone atsansone removed their assignment Jan 25, 2024
@atsansone atsansone changed the title Remove Dart FAQ Revise Dart FAQ Feb 1, 2024
@atsansone atsansone marked this pull request as ready for review February 2, 2024 19:18
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atsansone please create the issue to revisit

@atsansone atsansone merged commit 0a465d8 into dart-lang:main Feb 5, 2024
8 checks passed
atsansone added a commit to atsansone/site-www that referenced this pull request Feb 9, 2024
Revised for currency. @MaryaBelanger : Created a draft issue to revisit later. Thanks!

Fixes dart-lang#4673
atsansone added a commit to atsansone/site-www that referenced this pull request Feb 12, 2024
Revised for currency. @MaryaBelanger : Created a draft issue to revisit later. Thanks!

Fixes dart-lang#4673
atsansone added a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
Revised for currency. @MaryaBelanger : Created a draft issue to revisit later. Thanks!

Fixes dart-lang#4673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate and/or rewrite the FAQ
5 participants