Add code excerpts to new type promotion failures #5359
Conversation
|
I'm still not sure how to implement the excerpts for the I know there's a way to print the actual error from the excerpts too (I think the Fixing common type problems page does it), so tbd on that too. |
|
Visit the preview URL for this PR (updated for commit f722e2c): |
- Minor copy fixes - Limit textual lines to 80 characters - Add some missing return types to code snippets - Place link definitions near the usage of them - Use code font in a few more places where appropriate - Replace curly quotation marks with normal ones Landing this first to make finalizing #5359 easier.
|
@MaryaBelanger : Once you get this PR updated, I'll take another look. |
|
@MaryaBelanger : This was last touched by you in 2023. Do you think you can come back to this or should someone else pick it up? |
|
I took this one over and will try to get back to it this week. |
Co-authored-by: Marya Belanger <mbelanger@google.com>
There was a problem hiding this comment.
Thanks for doing this @MaryaBelanger, looks great to me!
I pulled out some of the copy fixes and clean up out into #5859, then rebased on top of that cleanup, and finally fixed the few remaining errors.
Excerpts added in #5246
Fixes #5350