docs: Mixins can have abstract methods #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFin
commented
Jul 5, 2023
| @@ -135,7 +135,7 @@ wrapping them with methods, all without changing client code. | |||
|
|
|||
| Instance, getter, and setter methods can be abstract, defining an | |||
| interface but leaving its implementation up to other classes. | |||
| Abstract methods can only exist in [abstract classes][]. | |||
| Abstract methods can only exist in [abstract classes][] or [mixins][]. | |||
|
|
|||
| To make a method abstract, use a semicolon (;) instead of a method body: | |||
|
|
|||
There was a problem hiding this comment.
May be useful to add a simple code example of an abstract getter in a mixin, but maybe that could be left to the mixins docs.
There was a problem hiding this comment.
Good idea. I think you're right though that it should be on the mixin page. It can potentially be added as part of #4871 :)
parlough
approved these changes
Jul 5, 2023
| @@ -135,7 +135,7 @@ wrapping them with methods, all without changing client code. | |||
|
|
|||
| Instance, getter, and setter methods can be abstract, defining an | |||
| interface but leaving its implementation up to other classes. | |||
| Abstract methods can only exist in [abstract classes][]. | |||
| Abstract methods can only exist in [abstract classes][] or [mixins][]. | |||
|
|
|||
| To make a method abstract, use a semicolon (;) instead of a method body: | |||
|
|
|||
There was a problem hiding this comment.
Good idea. I think you're right though that it should be on the mixin page. It can potentially be added as part of #4871 :)
rmacnak-google
pushed a commit
to rmacnak-google/site-www
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4767 (comment)
Contribution guidelines:
dart format.<?code-excerptneed to be updated in their source.dartfile as well.