Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who uses Dart (updated) #4601

Merged
merged 8 commits into from
Aug 4, 2024
Merged

Who uses Dart (updated) #4601

merged 8 commits into from
Aug 4, 2024

Conversation

MaryaBelanger
Copy link
Contributor

@MaryaBelanger MaryaBelanger commented Feb 15, 2023

This is a revision of #4577 (closing that in favor of this, added original author as co-author here) because I couldn't add changes to that contributor's fork. Thanks for getting this started @MikiPAUL!

Fixes #4144

Question for reviewers: I'm unsure why the page was taken down originally (archived here). Should I add that content to this PR?

@MaryaBelanger MaryaBelanger marked this pull request as ready for review February 15, 2023 23:46
@MaryaBelanger
Copy link
Contributor Author

@sfshaza2 @parlough I'm not 100% sold on this layout or organization, thoughts?

Copy link
Collaborator

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't really like the layout, either. Maybe wait for @mit-mit to return to ask him?

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes improve the page a lot. I would ask that some GSG changes be made. Thanks!

@mit-mit
Copy link
Member

mit-mit commented May 16, 2023

Hey @MaryaBelanger would be great to get this one landed now that we're past Dart 3.

@MaryaBelanger
Copy link
Contributor Author

@mit-mit sure thing, getting back to it now.

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Feb 11, 2024

Visit the preview URL for this PR (updated for commit a9ff6c4):

https://dart-dev--pr4601-patch-1-tw7qwrlr.web.app

@dart-lang dart-lang deleted a comment from github-actions bot Feb 11, 2024
Copy link
Collaborator

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. This looks pretty good, @MaryaBelanger! Though I am wondering if Wrike is still using AngularDart...

@sfshaza2
Copy link
Collaborator

@mit-mit @parlough, I'd like to land this PR. I think it's in good shape. However, it's been marked as Draft and I see no way to undo that.

@sfshaza2 sfshaza2 marked this pull request as ready for review July 31, 2024 21:56
@sfshaza2
Copy link
Collaborator

@mit-mit @parlough, nevermind! I was able to convert it. Landing. If you have any further issues with this page, please open an issue.

@sfshaza2 sfshaza2 closed this Jul 31, 2024
@sfshaza2 sfshaza2 reopened this Jul 31, 2024
@sfshaza2
Copy link
Collaborator

/gcbrun

1 similar comment
@sfshaza2
Copy link
Collaborator

/gcbrun

@sfshaza2
Copy link
Collaborator

@parlough, this PR is breaking staging. Can you fix and land? (I hate PRs that get this old and stanky, btw.)

MikiPAUL and others added 2 commits August 2, 2024 18:00
workiva typo fix

Co-authored-by: John Ryan <ryjohn@google.com>
@sfshaza2 sfshaza2 merged commit 629c272 into main Aug 4, 2024
10 checks passed
@kevmoo kevmoo deleted the patch-1 branch August 20, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 'Who uses Dart' page
7 participants