-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Who uses Dart (updated) #4601
Who uses Dart (updated) #4601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't really like the layout, either. Maybe wait for @mit-mit to return to ask him?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes improve the page a lot. I would ask that some GSG changes be made. Thanks!
Hey @MaryaBelanger would be great to get this one landed now that we're past Dart 3. |
@mit-mit sure thing, getting back to it now. |
Visit the preview URL for this PR (updated for commit a9ff6c4): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. This looks pretty good, @MaryaBelanger! Though I am wondering if Wrike is still using AngularDart...
/gcbrun |
1 similar comment
/gcbrun |
@parlough, this PR is breaking staging. Can you fix and land? (I hate PRs that get this old and stanky, btw.) |
workiva typo fix Co-authored-by: John Ryan <ryjohn@google.com>
workiva typo fix Co-authored-by: John Ryan <ryjohn@google.com>
Co-authored-by: MikiPaul <mikipaul46@gmail.com>
This is a revision of #4577 (closing that in favor of this, added original author as co-author here) because I couldn't add changes to that contributor's fork. Thanks for getting this started @MikiPAUL!
Fixes #4144
Question for reviewers: I'm unsure why the page was taken down originally (archived here). Should I add that content to this PR?