Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dart 2.4 banner link #1708

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Fix Dart 2.4 banner link #1708

merged 1 commit into from
Jun 27, 2019

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Jun 27, 2019

No description provided.

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jun 27, 2019
@mit-mit
Copy link
Member Author

mit-mit commented Jun 27, 2019

TBR @sfshaza2

@mit-mit mit-mit merged commit bda1970 into master Jun 27, 2019
@mit-mit mit-mit deleted the mit-mit-patch-1 branch June 27, 2019 20:38
@sfshaza2
Copy link
Collaborator

TBR? To be read? I had to google that and I’m still confused. :)

@mit-mit
Copy link
Member Author

mit-mit commented Jun 27, 2019

Sorry for the lingo, I was referring to it in the 'To Be Reviewed (after merge)'-sense: https://github.com/flutter/flutter/wiki/Tree-hygiene#landing-a-patch-in-a-hurry-for-emergencies

@sfshaza2
Copy link
Collaborator

sfshaza2 commented Jun 27, 2019 via email

@sfshaza2
Copy link
Collaborator

J’approve. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mit-mit @sfshaza2 @googlebot