Update base image of Cloud Build deploy image #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpryan
approved these changes
May 7, 2024
|
@parlough do you want to update the submodules too? |
|
@johnpryan Thanks for the review! If I understand correctly, we don't need to update the submodules for this change, as Cloud Build is setup to rebuild and upload the image from this repo (https://github.com/dart-lang/site-shared/runs/24691560315). Then the downstream repos use it from container/artifact registry or whatever? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 20.04 is getting a bit old, now two LTS behind. To prevent any future incompatibilities and prepare for the end of its LTS support in 2025, update to the latest Debian LTS (12), especially since our tooling might start to require newer dependency versions.
Beyond that, the original base image source
gcr.io/gcp-runtimesseems to be no longer updated, with no 22.04 image and the last 20.04 image uploaded on Jun 22, 2023. Potentially resulting in security concerns due to lack of security fixes.I found the new base image from https://cloud.google.com/software-supply-chain-security/docs/base-images which appears to be Google-built, supported, and locally cached.
\cc @khanhnwin for review