Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base image of Cloud Build deploy image #215

Merged
merged 1 commit into from
May 7, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Apr 13, 2024

Ubuntu 20.04 is getting a bit old, now two LTS behind. To prevent any future incompatibilities and prepare for the end of its LTS support in 2025, update to the latest Debian LTS (12), especially since our tooling might start to require newer dependency versions.

Beyond that, the original base image source gcr.io/gcp-runtimes seems to be no longer updated, with no 22.04 image and the last 20.04 image uploaded on Jun 22, 2023. Potentially resulting in security concerns due to lack of security fixes.

I found the new base image from https://cloud.google.com/software-supply-chain-security/docs/base-images which appears to be Google-built, supported, and locally cached.

\cc @khanhnwin for review

@parlough parlough requested a review from drewroengoogle April 13, 2024 10:12
@parlough parlough requested review from johnpryan and removed request for drewroengoogle May 2, 2024 13:31
@johnpryan johnpryan merged commit 0126475 into main May 7, 2024
8 checks passed
@johnpryan johnpryan deleted the misc/new-cloud-build-base-image branch May 7, 2024 16:42
@johnpryan
Copy link
Collaborator

@parlough do you want to update the submodules too?

@parlough
Copy link
Member Author

parlough commented May 7, 2024

@johnpryan Thanks for the review!

If I understand correctly, we don't need to update the submodules for this change, as Cloud Build is setup to rebuild and upload the image from this repo (https://github.com/dart-lang/site-shared/runs/24691560315). Then the downstream repos use it from container/artifact registry or whatever?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants