Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dart 3.2 language version #1340

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [3.2.0]
sdk: [3.2.6]
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
- uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3
Expand Down Expand Up @@ -49,8 +49,8 @@ jobs:
# TODO(sigurdm): our end2end test creates longer filenames than we can
# handle on windows. See https://github.com/dart-lang/sdk/issues/42416
os: [ubuntu-latest, macos-latest]
sdk: [3.2.0]
flutter: [3.16.0]
sdk: [3.2.6]
flutter: [3.16.9]
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
- uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
- uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3
with:
sdk: '3.3.0-120.0.dev' # TODO: switch back to rolling 'dev' channel after it gets updated.
sdk: '3.3.0-279.3.beta' # TODO: switch back to rolling 'dev' channel after it gets updated.
- uses: subosito/flutter-action@2783a3f08e1baf891508463f8c6653c258246225
with:
# flutter-version: '3.4.0-34.1.pre'
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.22.2-wip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we just set the final version here, not the -postfixed one.


- Require Dart 3.2.0 or later to use `pana`.

## 0.22.1

- Fix: unspecified `--dartdoc-version` will use the latest version in an isolated
Expand Down
2 changes: 1 addition & 1 deletion lib/src/sdk_env.dart
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ class ToolEnvironment {
'global',
'activate',
'dartdoc',
if (_dartdocVersion != null) _dartdocVersion!,
if (_dartdocVersion != null) _dartdocVersion,
],
environment: {
..._dartSdk.environment,
Expand Down
2 changes: 1 addition & 1 deletion lib/src/version.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: pana
description: PAckage aNAlyzer - produce a report summarizing the health and quality of a Dart package.
version: 0.22.1
version: 0.22.2-wip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we usually use -dev postfix.

repository: https://github.com/dart-lang/pana
topics:
- tool

environment:
sdk: '>=3.0.0 <4.0.0'
sdk: ^3.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any pressing need for this? Let's not force-upgrade people just for the sake of upgrading.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. Not necessary for now :)


dependencies:
analyzer: '>=5.0.0 <7.0.0'
Expand Down
4 changes: 2 additions & 2 deletions test/goldens/end2end/skiplist-0.1.0.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"grantedPoints": 0,
"maxPoints": 50,
"status": "failed",
"summary": "### [x] 0/50 points: code has no errors, warnings, lints, or formatting issues\n\n* Running `dart pub outdated` failed with the following output:\n\n```\nThe lower bound of \"sdk: '>=1.0.0 <=3.2.0'\" must be 2.12.0'\nor higher to enable null safety.\n```\n"
"summary": "### [x] 0/50 points: code has no errors, warnings, lints, or formatting issues\n\n* Running `dart pub outdated` failed with the following output:\n\n```\nThe lower bound of \"sdk: '>=1.0.0 <=3.2.6'\" must be 2.12.0'\nor higher to enable null safety.\n```\n"
},
{
"id": "dependency",
Expand All @@ -98,5 +98,5 @@
"maxPoints": 130
},
"urlProblems": [],
"errorMessage": "Running `dart pub outdated` failed with the following output:\n\n```\nThe lower bound of \"sdk: '>=1.0.0 <=3.2.0'\" must be 2.12.0'\nor higher to enable null safety.\n```"
"errorMessage": "Running `dart pub outdated` failed with the following output:\n\n```\nThe lower bound of \"sdk: '>=1.0.0 <=3.2.6'\" must be 2.12.0'\nor higher to enable null safety.\n```"
}
2 changes: 1 addition & 1 deletion test/goldens/end2end/skiplist-0.1.0.json_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Run `dart pub get` for more information.
* Running `dart pub outdated` failed with the following output:

```
The lower bound of "sdk: '>=1.0.0 <=3.2.0'" must be 2.12.0'
The lower bound of "sdk: '>=1.0.0 <=3.2.6'" must be 2.12.0'
or higher to enable null safety.
```

Expand Down