Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional CLI arguments for pana binary. #1327

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 2, 2024

  • [dart|flutter]-sdk is extended [dart|flutter]-config-home to have a better SdkConfig object.
  • [dartdoc|resources]-output for the files written by dartdoc and pana (e.g. webp screenshots)
  • dartdoc-timeout and total-time-budget to control how long pana tries to run (or abort processing).

@isoos isoos requested review from jonasfj and sigurdm February 2, 2024 12:17
@isoos
Copy link
Collaborator Author

isoos commented Feb 2, 2024

Note: I think total-time-budget may not be the best name, any suggestions?

@sigurdm
Copy link
Contributor

sigurdm commented Feb 2, 2024

Note: I think total-time-budget may not be the best name, any suggestions?

total-timeout ?

@isoos
Copy link
Collaborator Author

isoos commented Feb 2, 2024

total-timeout ?

I'm good with that, although, right now we don't really enforce it yet, only for reducing the dartdoc-timeout if we would be otherwise over the total. (I think later we could add some checks to really consider it as a timeout).

@isoos isoos merged commit acdbdbd into dart-lang:master Feb 2, 2024
5 checks passed
@isoos isoos deleted the pana branch February 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants