Dynamically reduce dartdoc timeout with total time budget option. #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Jan 25, 2024
| final Duration? dartdocTimeout; | ||
| final int? lineLength; | ||
|
|
||
| InspectOptions({ | ||
| this.pubHostedUrl, | ||
| this.dartdocOutputDir, | ||
| this.totalTimeBudget, |
There was a problem hiding this comment.
Could we document this a bit.
Can you pass both timeouts? How do they interact? Are there defaults?
There was a problem hiding this comment.
Updated this and other options. PTAL
sigurdm
approved these changes
Jan 25, 2024
Co-authored-by: Sigurd Meldgaard <sigurdm@google.com>
Co-authored-by: Sigurd Meldgaard <sigurdm@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address dart-lang/pub-dev#7430