Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some methods and method parameters from ToolEnvironment. #1316

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Remove some methods and method parameters from ToolEnvironment. #1316

merged 1 commit into from
Jan 16, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 16, 2024

  • '--no-validate-links' in dartdoc() is always set anyway, no need to keep the optional parameter (similarly the other parameters are never set, we can remove them).
  • removing further methods that are never called or restringing the visibility of them (_getFlutterVersion()).

@isoos isoos requested review from jonasfj and sigurdm January 16, 2024 13:39
sigurdm
sigurdm approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@isoos isoos merged commit 556ed22 into dart-lang:master Jan 16, 2024
5 checks passed
@isoos isoos deleted the remove-methods branch January 16, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @sigurdm