Remove further unused methods / making them private. (#1317)

CHANGELOG.md

@@ -2,14 +2,25 @@
 
 **BREAKING CHANGES**
 
-- Removed deprecated APIs.
-- Removed `InspectOptions.checkRemoteRepository` - repositories are verified by default.
 - Renamed `runProc` -> `runConstrained`.
-- Removed `ProcessOutput.asBytes`.
+- Removed:
+  - deprecated APIs
+  - `InspectOptions.checkRemoteRepository` - repositories are verified by default
+  - `ProcessOutput.asBytes`
+  - `ToolEnvironment`:
+    - removed parameters from `dartdoc()`
+    - `detectFlutterUse()`
+    - `get environment`
+    - `getFlutterVersion()`
+  - `analysisOptionsFiles`
+  - `changelogFileNames`
+  - `currentAnalysisOptionsFileName`
+  - `dartdocFailedSection`
+  - `firstFileFromNames`
+  - `licenseFileNames`
+  - `pubspecParseError`
+  - `readmeFileNames`
 - `ToolException` has reference to the entire `PanaProcessResult`, instead of just the `stderr`.
-- `ToolEnvironment`:
-  - removed parameters from `dartdoc()`
-  - removed `get environment`, `detectFlutterUse()` and `getFlutterVersion()`
 
 ## 0.21.45
 

lib/pana.dart

@@ -4,7 +4,7 @@
 
 export 'src/dartdoc_analyzer.dart';
 export 'src/download_utils.dart';
-export 'src/maintenance.dart';
+export 'src/maintenance.dart' show exampleFileCandidates;
 export 'src/model.dart';
 export 'src/package_analyzer.dart';
 export 'src/pubspec.dart';

lib/src/dartdoc_analyzer.dart

@@ -53,20 +53,3 @@ ReportSection documentationCoverageSection({
     status: accepted ? ReportStatus.passed : ReportStatus.failed,
   );
 }
-
-/// Creates a report section when running dartdoc failed to produce content.
-ReportSection dartdocFailedSection(String abortMessage) {
-  return ReportSection(
-    id: ReportSectionId.documentation,
-    title: documentationSectionTitle,
-    grantedPoints: 0,
-    maxPoints: 10,
-    summary: renderSimpleSectionSummary(
-      title: 'Failed to run dartdoc',
-      description: abortMessage,
-      grantedPoints: 0,
-      maxPoints: 10,
-    ),
-    status: ReportStatus.failed,
-  );
-}

lib/src/license.dart

@@ -12,12 +12,13 @@ import 'package:meta/meta.dart';
 import 'package:pana/src/license_detection/license_detector.dart' hide License;
 import 'package:path/path.dart' as p;
 
-import 'maintenance.dart';
 import 'model.dart';
 
+const _licenseFileNames = ['LICENSE'];
+
 Future<List<License>> detectLicenseInDir(String baseDir) async {
   final licenses = <License>[];
-  for (final candidate in licenseFileNames) {
+  for (final candidate in _licenseFileNames) {
     final file = File(p.join(baseDir, candidate));
     if (!file.existsSync()) continue;
     licenses.addAll(await detectLicenseInFile(file, relativePath: candidate));

lib/src/maintenance.dart

@@ -6,9 +6,6 @@ library pana.maintenance;
 
 import 'package:json_annotation/json_annotation.dart';
 
-const changelogFileNames = ['CHANGELOG.md'];
-const readmeFileNames = ['README.md'];
-
 /// Returns the candidates in priority order to display under the 'Example' tab.
 List<String> exampleFileCandidates(String package) {
   return <String>[
@@ -25,28 +22,6 @@ List<String> exampleFileCandidates(String package) {
   ];
 }
 
-const licenseFileNames = ['LICENSE'];
-
-const String currentAnalysisOptionsFileName = 'analysis_options.yaml';
-final List<String> analysisOptionsFiles = const [
-  currentAnalysisOptionsFileName,
-  '.analysis_options',
-];
-
-String? firstFileFromNames(List<String> files, List<String> names,
-    {bool caseSensitive = false}) {
-  for (var name in names) {
-    for (var file in files) {
-      if (file == name) {
-        return file;
-      } else if (!caseSensitive && file.toLowerCase() == name) {
-        return file;
-      }
-    }
-  }
-  return null;
-}
-
 /// Returns a markdown-formatted error message for pubspec.yaml parse error.
 String pubspecParseError(error) {
   // TODO: remove this after json_annotation is updated with CheckedFromJsonException.toString()