Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartpad_ui] Minor clean up and simplifications #3059

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Sep 21, 2024

  • Avoids dynamic being introduced
  • Reduces duplicate theme discovery
  • Enables using const in a few more spots
  • Uses language features in a few more spots where possible

Copy link

github-actions bot commented Sep 21, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/default_dart.dart
pkgs/samples/lib/default_flutter.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart
pkgs/samples/tool/samples.dart
Package publish validation ✔️
Package Version Status

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@parlough parlough requested a review from devoncarew September 24, 2024 19:06
@parlough parlough changed the title Minor clean up and simplifications [dartpad_ui] Minor clean up and simplifications Sep 24, 2024
@parlough parlough merged commit 61c036b into main Sep 24, 2024
16 checks passed
@parlough parlough deleted the misc/minor-cleanup branch September 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants