Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore cursor pos after formatting #2885

Merged
merged 2 commits into from
Mar 7, 2024
Merged

restore cursor pos after formatting #2885

merged 2 commits into from
Mar 7, 2024

Conversation

devoncarew
Copy link
Member

  • restore cursor pos after formatting
  • fix a JS interop issue with the goLineLeft command (we'd throw an NPE from interop code when trying to return a null result)

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested a review from parlough February 29, 2024 19:22
@johnpryan johnpryan merged commit b2594ea into main Mar 7, 2024
4 checks passed
@johnpryan johnpryan deleted the formatting_pos branch March 7, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants