Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support older gist formats #2880

Merged
merged 1 commit into from
Feb 29, 2024
Merged

support older gist formats #2880

merged 1 commit into from
Feb 29, 2024

Conversation

devoncarew
Copy link
Member

This restores support for older (mostly unintentional) gists formats; loading from a gist with a single dart file in the gist with any name. We do now nag about the gist - that authors should prefer naming the gist file main.dart.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works well with the scenarios I tried.

@devoncarew devoncarew merged commit d4f8b6a into main Feb 29, 2024
4 checks passed
@devoncarew devoncarew deleted the support_older_gists branch February 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants