Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of late from Sdk configuration #2814

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 7, 2024

late always makes me feel a bit uneasy and it results in a stub being used every time the field is accessed. We can avoid the usages in the Sdk class with a factory constructor :)

@johnpryan johnpryan merged commit 254e5ac into main Feb 8, 2024
6 checks passed
@johnpryan johnpryan deleted the misc/cleanup-sdk-late-usages branch February 8, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants