Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use text button for keyboard shortcuts #2813

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Xazin
Copy link
Contributor

@Xazin Xazin commented Feb 5, 2024

Part of #2747 - Replaces the IconButton with a TextButton, to make the style of the buttons uniform. This seems like a better method than to try to make the IconButton adhere to the style of the TextButton.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


Screen.Recording.2024-02-05.at.23.01.35.mov

@johnpryan johnpryan merged commit 36b9f34 into dart-lang:main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants