Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing header Firefox requires for communicating with frame #2804

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Jan 31, 2024

Without this, Firefox errors when trying to communicate with the running frame.

I don't fully understand but this Cross-Origin-Resource-Policy config is needed to go along with the Cross-Origin-Embedder-Policy to indicate the frame results can be embedded. Relationship to cross-origin embedder policy (COEP) has some more context.

@parlough parlough requested a review from johnpryan January 31, 2024 04:44
Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

@johnpryan johnpryan merged commit a736b7d into main Jan 31, 2024
4 checks passed
@johnpryan johnpryan deleted the fix/new-ui-cors branch January 31, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants