Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all popupmenus to material 3 menus #2785

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Jan 5, 2024

Updates all popup menus to use the Material 3 MenuAnchor menu. This menu opens instantly (compared to the Material 2 menu which fades slowly in), making the site be perceived as more snappy and more like other web apps.

@devoncarew
Copy link
Member

Thanks! @mit-mit - can you post some before and after pics for context? And typically, we like a brief description of the PR.

@mit-mit
Copy link
Member Author

mit-mit commented Jan 8, 2024

Added a description.

The main difference is in how the opening of the menus "feel", so that is really hard to capture in a screenshot. I recommend trying to run it.

@devoncarew
Copy link
Member

Pictures w/ UI affecting PRs are useful in order to compare the before and after - it's not always clear what's going on just from the code.

For example, the menu buttons look the same here:

before:

Screenshot 2024-01-08 at 9 45 54 AM

after:

Screenshot 2024-01-08 at 9 46 52 AM

but the menu's themselves have regressed (wrt icon size, item padding, ...):

before:

Screenshot 2024-01-08 at 9 45 59 AM

after:

Screenshot 2024-01-08 at 9 46 57 AM

@mit-mit
Copy link
Member Author

mit-mit commented Jan 8, 2024

the menu's themselves have regressed

I'm not sure those are all regressions? The spec changed in material 3:
https://m3.material.io/components/menus/specs

But I am a bit puzzled about the icon height. If left to the old value -- which seems to follow the spec -- then it visually looks much larger than what the screenshots in the spec require.

@mit-mit
Copy link
Member Author

mit-mit commented Feb 7, 2024

I'd really like to land this before the next release, as these new menu widgets are much more performant. @devoncarew are we blocked on the icons? if so, I can tear those changes out.

@devoncarew
Copy link
Member

Yeah, the visual changes - which look like undesired regressions - are the icon sizes and the padding around the items. I expect these will be straightforward to fix.

FYI that the (significant) perf drop-off we saw a few weeks ago - both in some versions of chrome and in firefox - are no longer present (due to framework updates).

To be clear, I have no objections whatsoever to this PR as long as we're intentional w/ the UI changes; I just suspect the ones above are regressions.

@mit-mit
Copy link
Member Author

mit-mit commented Feb 7, 2024

Updated PTAL @devoncarew
Screenshot 2024-02-08 at 00 11 30
Screenshot 2024-02-08 at 00 11 26

@mit-mit mit-mit merged commit ff5175a into dart-lang:main Feb 8, 2024
2 checks passed
@mit-mit mit-mit deleted the mat3menus branch February 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants