Add back check for invalid core library imports #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
93dc547 simplified import handling but no longer reported invalid Dart core library imports. Since then I've seen a few cases of people posting DartPad screenshots trying to use VM-only libraries.
To prevent any confusion, this PR reintroduces checks and reports warnings if a user tries to import a core library that won't work.
It also introduces support for indicating a core web library as deprecated. For now this only includes
dart:js, but likely will expand todart:htmlanddart:js_utilin the future. It doesn't include the other web libraries likedart:web_gl,dart:web_audio, etc since they are already resulting in errors in the DartPad frontend.