Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Conversation] Add HTTP python and js tabs to the quickstart #4528

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

hhunter-ms
Copy link
Collaborator

Add tabs with instructions for the HTTP samples until SDK is available

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms added this to the 1.15 milestone Feb 11, 2025
@hhunter-ms hhunter-ms self-assigned this Feb 11, 2025
@hhunter-ms hhunter-ms requested review from a team as code owners February 11, 2025 20:45
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The one fix is that I notice the conversation API needs to be added into the table here https://v1-15.docs.dapr.io/getting-started/quickstarts/ (it is in the index currently)

Also in the same file I think it is time we change this note "
We are actively working on adding to our quickstart library. In the meantime, you can explore Dapr through our [tutorials]"

to say something like this? Thoughts?

"Each release, the quickstart library has new examples added for the APIs and SDKs. You can also explore Dapr through the tutorials.

hhunter-ms and others added 2 commits February 12, 2025 12:10
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 021bc38 into dapr:v1.15 Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants