Slombard/web 312 add ipv6 addressees to the multi server test #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantol29
reviewed
May 19, 2024
This is tricky. The subject or the eval sheet say it should not work if you listen to the same port. But different IP and same port make totally sense, like if you have the Ethernet cables connected with your computer, and you want to listen for a certain websites only to two of them. You'll have 2 listen in the same server_block with differen IPs and same port. No? |
dantol29
approved these changes
May 20, 2024
552020
deleted the
slombard/web-312-add-ipv6-addressees-to-the-multi-server-test
branch
552020
restored the
slombard/web-312-add-ipv6-addressees-to-the-multi-server-test
branch
552020
deleted the
slombard/web-312-add-ipv6-addressees-to-the-multi-server-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has tests now also for IPv6.
IPv6 needs to be enabled in Docker though.
In the Markdown the are instructions on how to do it.
We have 4 different scripts. 3 out of 4 are working, the last not, cause the config parser is not happy with the one with the mixed addresses with the same port. Anyway the server is definetevly working with multiple ip:ports combination (with different server sockets) for Ipv4 and IPv6.
IPv6 was not even part of the subject btw.