Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add docker-in-docker feature to devcontainer #381

Merged

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Mar 24, 2024

Description

The new hadolint pre-commit hook fails if the user doesn't have docker installed. To ensure our devcontainers continue to work "out of the box" we are adding the docker-in-docker feature to provide the needed executable.

Please also link to any relevant issues that your code is associated with.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

The new hadolint pre-commit hook fails if the user doesn't have docker installed. To ensure our devcontainers continue to work "out of the box" we are adding the docker-in-docker feature to provide the needed executable.
@kenibrewer kenibrewer requested a review from d33bs March 24, 2024 22:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (af5a4ef) to head (270f603).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #381   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          56       56           
  Lines        3137     3137           
=======================================
  Hits         2979     2979           
  Misses        158      158           
Flag Coverage Δ
unittests 94.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update! Apologies about incurring this through recent related changes. LGTM.

Co-authored-by: Dave Bunten <ekgto445@gmail.com>
@kenibrewer kenibrewer merged commit 16f3500 into cytomining:main Mar 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants