Use all-in-one blorbs that contain story + graphics/sound #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've filed curiousdannii/frotz#1 … once that merges, this PR should no longer be buggy. |
dfabulich
force-pushed
the
story-blorbs
branch
from
dbb3aa3 to
154b751
Compare
|
Even with your fix to Frotz, it still shows an error message for sounds, and doesn't play the sound. So I've switched the sound games back to having separate blorbs. Ah, I see that the sound code prints an error and returns, unlike the graphics code which continues to try to draw it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apropos #15, this PR uses all-in-one blorbs containing the story + graphics/sound for all games.
It's buggy, though. I believe we're seeing https://gitlab.com/DavidGriffith/frotz/-/issues/287 in action. I'll file a PR on https://github.com/curiousdannii/frotz to address it.