Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message for VersionsReversed error #63

Closed
wants to merge 1 commit into from
Closed

Fix message for VersionsReversed error #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Any contribution is more than welcomed. For now, no specific rule must be applie

OpenApi Comparator is an Open Source software released under the [Apache 2.0 license](https://github.com/criteo/openapi-comparator/blob/main/LICENCE).

## Developper guide
## Developer guide

Simply use the dotnet cli. For example, to run the tests:
```bash
Expand Down
2 changes: 1 addition & 1 deletion src/Criteo.OpenApi.Comparator.UTest/Resource/version_reversed/diff.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"Severity": "Error",
"Message": "The new version has a lower value than the old: System.String[] -\u003E System.String[]",
"Message": "The new version has a lower value than the old: 2.0 -> 1.0",
"OldJsonRef": "#/info/version",
"NewJsonRef": "#/info/version",
"OldJsonPath": "#/info/version",
Expand Down
4 changes: 2 additions & 2 deletions src/Criteo.OpenApi.Comparator/Comparators/OpenApiDocumentComparator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ private static void CompareVersions(ComparisonContext context, string oldVersion

if (oldMajor > newMajor)
{
context.LogError(ComparisonRules.VersionsReversed, oldVersionAsList, newVersionAsList);
context.LogError(ComparisonRules.VersionsReversed, oldVersion, newVersion);
}
}

Expand All @@ -128,7 +128,7 @@ private static void CompareVersions(ComparisonContext context, string oldVersion

if (oldMinor > newMinor)
{
context.LogError(ComparisonRules.VersionsReversed, oldVersionAsList, newVersionAsList);
context.LogError(ComparisonRules.VersionsReversed, oldVersion, newVersion);
}
}
}
Expand Down