change order of time() params

cosmastech · Jul 10, 2024 · fa87890 · fa87890
1 parent 23291c7
commit fa87890
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Adapters/Concerns/TimeClosureTrait.php b/src/Adapters/Concerns/TimeClosureTrait.php
@@ -7,7 +7,7 @@ trait TimeClosureTrait
     /**
      * @inheritDoc
      */
-    public function time(string $stat, callable $closure, float $sampleRate = 1.0, array $tags = [])
+    public function time(callable $closure, string $stat, float $sampleRate = 1.0, array $tags = [])
     {
         $startTime = intval($this->clock->now()->format("Uv"));
 

diff --git a/src/Adapters/StatsDClientAdapter.php b/src/Adapters/StatsDClientAdapter.php
@@ -16,13 +16,13 @@ public function timing(string $stat, float $durationMs, float $sampleRate = 1.0,
     /**
      * Record a timing stat for the duration of the $closure.
      *
-     * @param  string  $stat
      * @param  callable  $closure
+     * @param  string  $stat
      * @param  float  $sampleRate
      * @param  array<mixed, mixed>  $tags
      * @return mixed The return value of $closure
      */
-    public function time(string $stat, callable $closure, float $sampleRate = 1.0, array $tags = []);
+    public function time(callable $closure, string $stat, float $sampleRate = 1.0, array $tags = []);
 
     /**
      * @param  string  $stat

diff --git a/tests/Adapters/InMemory/InMemoryTimingTest.php b/tests/Adapters/InMemory/InMemoryTimingTest.php
@@ -94,7 +94,7 @@ public function time_storesDurationOfClosure(): void
         $closure = fn () => "abc";
 
         // When
-        $actualReturn = $inMemoryClient->time("my-stat", $closure);
+        $actualReturn = $inMemoryClient->time($closure, "my-stat");
 
         // Then
         self::assertEquals("abc", $actualReturn);