-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gradle wrapper to latest version (8.13) #437
base: main
Are you sure you want to change the base?
Conversation
In prep for full Java 21 support, gradle needs to be updated to version 8.5 or later. https://docs.gradle.org/8.5/release-notes.html#java-21 https://docs.gradle.org/8.5/userguide/compatibility.html#java Updating gradle to latest version available now (8.13). Also upgrading plugin 'com.google.osdetector' to version '1.7.3' to fix gradle deprecation warnings.
bcde4b7
to
5aab64b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were these updates auto-generated in the upgrade? if so, by which command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, gradlew gets generated when you initialize a gradle project. The expectation is to generate it, check it into the repo, and not touch it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, if you already have gradle 8.1 (the 'latest' label was introduced since 8.1)
gradle wrapper --gradle-wrapper latest
or you could specify the exact version if upgrading from lower versions
gradle wrapper --gradle-wrapper 8.13
.
The command updates the gradle.properties, the wrapper JAR, gradlew, & gradlew.bat.
The changes related to exec commands are manual (to fix a deprecated warning for exec API and use the new providers.exec API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the CI failures are false alarms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The legacy platform CI task is failing due to libc linker issues. We don't need the latest version of gradle to work on that, but we do need to ensure that we can compile ACCP's native code successfully on the version of GCC present on that machine.
Caused by: java.lang.UnsatisfiedLinkError: /root/.gradle/native/0.2.7/x86_64-linux-gnu/libgradle-fileevents.so: /lib/libc.so.6: version `GLIBC_2.14' not found (required by /root/.gradle/native/0.2.7/x86_64-linux-gnu/libgradle-fileevents.so)
Upgrade gradle wrapper to latest version (8.13)
Issue #: 332
Description of changes:
In prep for full Java 21 support, gradle needs to be updated to version 8.5 or later.
https://docs.gradle.org/8.5/release-notes.html#java-21
https://docs.gradle.org/8.5/userguide/compatibility.html#java
Updating gradle to latest version available now (8.13).
Also upgrading plugin 'com.google.osdetector' to version '1.7.3' to fix gradle deprecation warnings.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.