Avoid accessing RSA struct's internals directly #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geedo0
approved these changes
Mar 21, 2024
| // RSA blinding can't be performed without |e|; 0 indicates |e|'s absence. | ||
| rsa->flags |= RSA_FLAG_NO_BLINDING; | ||
| res = RSA_set0_key(rsa, modulus, NULL, privExp); | ||
| // RSA blinding can't be performed without |e|. |
There was a problem hiding this comment.
nit: suggest moving this comment to doc comment for RSA_new_private_key_no_e
There was a problem hiding this comment.
I'll fix that in the next PR.
Comment on lines
+191
to
+193
| // We need to change this API once AWS-LC provides a method similar to the following: | ||
| // https://github.com/google/boringssl/blob/master/include/openssl/rsa.h#L630 | ||
| RSA_blinding_off_temp_for_accp_compatibility(rsa); |
There was a problem hiding this comment.
should we file an Issue against AWS-LC for a stable API to accomplish this?
There was a problem hiding this comment.
AWS-LC has this on their radar.
WillChilds-Klein
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
AWS-LC has made the RSA struct opaque. This PR replaces direct accesses to internals of RSA struct with API calls. The FIPS builds do not have an API to disable blinding, therefore, for FIPS builds we still keep accessing the internals until a similar API is provided.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.