Fix ArrayIndexOutOfBoundsException when no space needed #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geedo0
previously approved these changes
Mar 12, 2024
amirhosv
previously approved these changes
Mar 12, 2024
SalusaSecondus
force-pushed
the
gcmbuffertest
branch
from
fc53459 to
6cffebe
Compare
|
Rebased the changes. |
amirhosv
approved these changes
Mar 12, 2024
geedo0
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACCP incorrectly rejects GCM decryption when no output space is needed and is not provided. ACCP does correctly handle the case when the output buffer is an empty array but fails if the array is not empty. This change fixes this behavior and brings it into agreement with the default GCM implementation provided by the JDK.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.